Hi All, Unforunately v4 still had an issue with do_div() usage, so here is v5. This is also available in this branch: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-ov2680 Changes in v5: - Add some notes to the ACPI support commit message about the OVTI2680 HID - Make pixel_rate u64 instead of s64 for do_div() to fix: drivers/media/i2c/ov2680.c:1092:2: warning: comparison of distinct pointer types ('typeof ((sensor->pixel_rate)) *' (aka 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types] Changes in v4: - Rebase on top of latest sailus/media_tree/master (69142f89b61e) - Do not set v4l2_subdev.fwnode (let v4l2-core do endpoint matching) - Make enum_frame_interval() input checks more strict - Make enum_frame_size() returned full-size + binned-/quarter-size - Use V4L2_CID_ANALOGUE_GAIN for gain - 3 new patches: "media: ov2680: Add bus-cfg / endpoint property verification" "media: ipu-bridge: Add link-frequency to OV2680 ipu_supported_sensors[] entry" "media: atomisp: Drop atomisp-ov2680 sensor driver" Changes in v3: - Add Rui Miguel Silva's Ack for the series - 2 small fixes for remarks from Andy - Add a new patch adding me as co-maintainer in MAINTAINERS Changes in v2 - Drop "media: Add MIPI CCI register access helper functions" (being reviewed in its own thread / patch-submission) - Drop "media: ov2680: Add g_skip_frames op support" - Add "media: ov2680: Fix regulators being left enabled on ov2680_power_on() errors" - Add "media: ov2680: Add link-freq and pixel-rate controls" with this the driver now works on IPU3 with ipu3-capture.sh (libcamera support requires adding a couple more controls) - Limit line length to 80 chars everywhere - Address various small remarks from Andy During all the work done on the atomisp driver I have mostly been testing on devices with an ov2680 sensor. As such I have also done a lot of work on the atomisp-ov2680.c atomisp specific sensor driver. With the latest atomisp code from: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/tag/?h=media-atomisp-6.5-1 The atomisp code can now work with standard v4l2 sensor drivers using the selections (crop-tgt) api and v4l2-async sensor driver registration. This patch series modifies the main drivers/media/i2c/ov2680.c driver to add bugfixes, ACPI enumeration, selection API support and further improvments. After this the driver can be used with the atomisp driver and atomisp-ov2680.c can be dropped. This also gets the driver much closer to having everything needed for use with IPU3 / libcamera. I have a Lenovo Miix 510 now with an IPU3 + ov2680 sensor and with this series raw-capture using the ipu3-capture.sh script works. I plan to work on libcamera support for this in the near future. Regards, Hans Hans de Goede (32): media: ov2680: Remove auto-gain and auto-exposure controls media: ov2680: Fix ov2680_bayer_order() media: ov2680: Fix vflip / hflip set functions media: ov2680: Remove VIDEO_V4L2_SUBDEV_API ifdef-s media: ov2680: Don't take the lock for try_fmt calls media: ov2680: Add ov2680_fill_format() helper function media: ov2680: Fix ov2680_set_fmt() which == V4L2_SUBDEV_FORMAT_TRY not working media: ov2680: Fix regulators being left enabled on ov2680_power_on() errors media: ov2680: Convert to new CCI register access helpers media: ov2680: Store dev instead of i2c_client in ov2680_dev media: ov2680: Add runtime-pm support media: ov2680: Check for "powerdown" GPIO con-id before checking for "reset" GPIO con-id media: ov2680: Drop is_enabled flag media: ov2680: Add support for more clk setups media: ov2680: Add support for 19.2 MHz clock media: ov2680: Wait for endpoint fwnode before continuing with probe() media: ov2680: Add support for ACPI enumeration media: ov2680: Fix ov2680_enum_frame_interval() media: ov2680: Annotate the per mode register setting lists media: ov2680: Add ov2680_mode struct media: ov2680: Make setting the mode algorithm based media: ov2680: Add an __ov2680_get_pad_format() helper function media: ov2680: Implement selection support media: ov2680: Fix exposure and gain ctrls range and default value media: ov2680: Add a bunch of register tweaks media: ov2680: Drop unnecessary pad checks media: ov2680: Read and log sensor revision during probe media: ov2680: Add link-freq and pixel-rate controls media: ov2680: Add bus-cfg / endpoint property verification MAINTAINERS: Add Hans de Goede as OV2680 sensor driver maintainer media: ipu-bridge: Add link-frequency to OV2680 ipu_supported_sensors[] entry media: atomisp: Drop atomisp-ov2680 sensor driver MAINTAINERS | 1 + drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/ov2680.c | 1380 +++++++++-------- drivers/media/pci/intel/ipu-bridge.c | 2 +- drivers/staging/media/atomisp/i2c/Kconfig | 13 - drivers/staging/media/atomisp/i2c/Makefile | 1 - .../media/atomisp/i2c/atomisp-ov2680.c | 828 ---------- drivers/staging/media/atomisp/i2c/ov2680.h | 173 --- 8 files changed, 752 insertions(+), 1647 deletions(-) delete mode 100644 drivers/staging/media/atomisp/i2c/atomisp-ov2680.c delete mode 100644 drivers/staging/media/atomisp/i2c/ov2680.h -- 2.41.0
