Hi Hans,
Hans Verkuil wrote:
> On Tuesday, October 05, 2010 17:30:21 Guennadi Liakhovetski wrote:
>> On Tue, 5 Oct 2010, Sakari Ailus wrote:
...
>>>> +/**
>>>> + * struct v4l2_mbus_framefmt - frame format on the media bus
>>>> + * @width: frame width
>>>> + * @height: frame height
>>>> + * @code: data format code
>>>> + * @field: used interlacing type
>>>> + * @colorspace: colorspace of the data
>>>> + */
>>>> +struct v4l2_mbus_framefmt {
>>>> + __u32 width;
>>>> + __u32 height;
>>>> + __u32 code;
>>>> + enum v4l2_field field;
>>>> + enum v4l2_colorspace colorspace;
>>>> +};
>>>
>>> I think this struct would benefit from some reserved fields since it's
>>> part of the user space interface.
>>
>> IIUC, this struct is not going to be used in ioctl()s, that's what struct
>> v4l2_subdev_mbus_code_enum is for. But in this case - why don't we make
>> the "code" field above of type "enum v4l2_mbus_pixelcode"?
>
> Hmm, if it is not part of the public API, then it doesn't belong here at all.
>
> media/v4l2-mediabus.h should be split in a media header and a linux header in
> that case.
The struct is embedded in other the ioctl structures, so it _is_ part of
the public API, although not used directly as an ioctl argument. Those
structs are added by patch 9.
Cheers,
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
