Re: [PATCH/RFC v3 01/11] v4l: Move the media/v4l2-mediabus.h header to include/linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guennadi!

Guennadi Liakhovetski wrote:
> On Tue, 5 Oct 2010, Sakari Ailus wrote:
...
>>> +/**
>>> + * struct v4l2_mbus_framefmt - frame format on the media bus
>>> + * @width:	frame width
>>> + * @height:	frame height
>>> + * @code:	data format code
>>> + * @field:	used interlacing type
>>> + * @colorspace:	colorspace of the data
>>> + */
>>> +struct v4l2_mbus_framefmt {
>>> +	__u32				width;
>>> +	__u32				height;
>>> +	__u32				code;
>>> +	enum v4l2_field			field;
>>> +	enum v4l2_colorspace		colorspace;
>>> +};
>>
>> I think this struct would benefit from some reserved fields since it's
>> part of the user space interface.
> 
> IIUC, this struct is not going to be used in ioctl()s, that's what struct 
> v4l2_subdev_mbus_code_enum is for. But in this case - why don't we make 

Oh, you're right. My mistake.

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux