Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

Thank you for your comments.

On 2023/7/26 18:58, Bryan O'Donoghue wrote:
> On 19/06/2023 12:28, Jack Zhu wrote:
>> Add basic platform driver for StarFive Camera Subsystem.
> 
> Another nit here.
> 
> "Add basic driver" isn't a great title. Recommend "Add core driver".
> 
> Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc.
> 
> Use "core" not "basic" to describe this.
> 

Ok, I will modify this title.

> ---
> bod
> 

-- 
Regards,

Jack Zhu



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux