Em 28-09-2010 14:48, Jan Hoogenraad escreveu: > Douglas: > > I have an updated make_kconfig.pl for Ububtu on: > http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl > > Could you test if make allyesconfig actually keeps FIREDTV enabled on a non-Ubuntu system ? > > If so, can you merge this version into the main stream ? > > > Mauro: > > You are very right. I did not look far enough. > > The expanded place where I expect the dma.h file would be (as I > /lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h > > note that the letters "el" should be removed from your first expression > $dmahplace="$kernelsrc/include/config/ieee1394/dma.h"; > needs to be: > $dmahplace="$kernsrc/include/config/ieee1394/dma.h"; > > Thanks a lot for helping ! > > > As patch, relative to the diff you sent: > > # HG changeset patch > # User Jan Hoogenraad <jan-conceptronic@xxxxxxxx> > # Date 1285695899 -7200 > # Node ID 891128e7c3334e41f6c173ee5c01fddbce493b73 > # Parent cb34ee1c29fc8891ad3792b3df76031a72e39b9d > Location fix > > From: Jan Hoogenraad <jan-conceptronic@xxxxxxxx> > > Location fix > > Priority: normal > > Signed-off-by: Jan Hoogenraad <jan-conceptronic@xxxxxxxx> > > diff -r cb34ee1c29fc -r 891128e7c333 v4l/scripts/make_kconfig.pl > --- a/v4l/scripts/make_kconfig.pl Mon Sep 27 20:27:20 2010 +0200 > +++ b/v4l/scripts/make_kconfig.pl Tue Sep 28 19:44:59 2010 +0200 > @@ -688,10 +688,7 @@ > # Check for full kernel sources and print a warning > sub dmahcheck() > { > - my $dmahplace= "".$kernsrc; > - $dmahplace =~ s-^/lib/modules/--g; > - $dmahplace =~ s-/.*$--g; > - $dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h"; > + my $dmahplace="$kernsrc/include/config/ieee1394/dma.h"; > if (! -e $dmahplace) { > print <<"EOF2"; Ok, now it looks correct on my eyes, and it should not hurt compilation with make release and with distros that do a good job with their kernel packages. I'll let Douglas review and test, as he is the maintainer. It would be better if you could send him a diff. you may use hg diff to generate it against an older version, in order to merge all your make_kconfig.pl patches, or just create a new clone from master and apply it there. A side question: when do you intend to send us the patches for the Realtek rtl2831? Cheers, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
