Hi Sakari, On 6/14/23 18:05, sakari.ailus@xxxxxxxxxxxxxxx wrote: > Hi Hans, > > On Wed, Jun 14, 2023 at 05:47:01PM +0200, Hans de Goede wrote: >> Hi All, >> >> The ov5693 driver uses v4l2_subdev_get_try_crop() / >> v4l2_subdev_get_try_format() both of which are >> only defined if CONFIG_VIDEO_V4L2_SUBDEV_API=y . >> >> Yet it does not do select VIDEO_V4L2_SUBDEV_API >> in its Kconfig bits ? >> >> Note I've not seen any build errors because of this, >> I guess we somehow end up getting away with this... >> >> But still I think the select should be added ? > > I agree. > > The reason there haven't been compile failures is that there's a vast > number of sensor drivers that all select this so for a failure you'd need > to select this one but none of the others. > > I can send a fix. Also see my follow-up email. If we're going to fix this we really should fix it properly. As mentioned in my folow-up email an intermediate Kconfig option might be best. E.g. doing: grep -l v4l2_async_register_subdev drivers/media/i2c/*.c And comparing that to Kconfig finds the following Kconfig entries lacking a select V4L2_FWNODE / select V4l2_ASYNC VIDEO_IMX208 VIDEO_IMX258 VIDEO_IMX274 VIDEO_IMX319 VIDEO_IMX355 VIDEO_OV6650 VIDEO_OV7740 VIDEO_OV9640 VIDEO_OV9650 and I stopped checking after the ov* drivers since I think the above list makes my point. Regards, Hans
