Hi Hans, On Wed, Jun 14, 2023 at 05:47:01PM +0200, Hans de Goede wrote: > Hi All, > > The ov5693 driver uses v4l2_subdev_get_try_crop() / > v4l2_subdev_get_try_format() both of which are > only defined if CONFIG_VIDEO_V4L2_SUBDEV_API=y . > > Yet it does not do select VIDEO_V4L2_SUBDEV_API > in its Kconfig bits ? > > Note I've not seen any build errors because of this, > I guess we somehow end up getting away with this... > > But still I think the select should be added ? I agree. The reason there haven't been compile failures is that there's a vast number of sensor drivers that all select this so for a failure you'd need to select this one but none of the others. I can send a fix. -- Regards, Sakari Ailus
