Re: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 6/12/23 16:18, Andy Shevchenko wrote:
> On Mon, Jun 12, 2023 at 5:16 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> acpi_object.integer.value is 64 bit, so to get bits 31-24
>> the value not only needs to be shifted but also masked.
> 
> Why? The type of active_value is u8. How does this make any difference?

Ah right I forgot about that, I'll drop this patch and drop the & 0xff for the second patch.

Regards,

Hans




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux