Re: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Mon, 12 Jun 2023 17:18:52 +0300
Cc: Andy Shevchenko <andy@xxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Dan Scally <dan.scally@xxxxxxxxxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx
In-reply-to: <20230612141632.5232-1-hdegoede@redhat.com>

On Mon, Jun 12, 2023 at 5:16 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> acpi_object.integer.value is 64 bit, so to get bits 31-24
> the value not only needs to be shifted but also masked.

Why? The type of active_value is u8. How does this make any difference?

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value
  - From: Hans de Goede

References:
- [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value
  - From: Hans de Goede

Prev by Date: [PATCH 3/3] Documentation: media: cec: describe new callbacks
Next by Date: Re: [PATCH 2/2] platform/x86: int3472: discrete: Log a warning if the pin-numbers don't match
Previous by thread: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value
Next by thread: Re: [PATCH 1/2] platform/x86: int3472: discrete: Fix getting active_value
Index(es):
- Date
- Thread

[Index of Archives] [Linux Input] [Video for Linux] [Gstreamer Embedded] [Mplayer Users] [Linux USB Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux