On Wed, Jun 07, 2023 at 06:47:01PM +0200, Hans de Goede wrote: > Add an acpi_match_table now that all the other bits necessary for > ACPI support are in place. ... > .name = "ov2680", > .pm = pm_sleep_ptr(&ov2680_pm_ops), > .of_match_table = of_match_ptr(ov2680_dt_ids), Side note. If we don't have OF dependency, this may provoke defined but not used. That's why I eagerly remove of_match_ptr() from the ID tables. Besides that, however might not be applicable right now, this will allow to use PRP0001 ACPI HID. > + .acpi_match_table = ov2680_acpi_ids, > }, > .probe_new = ov2680_probe, > .remove = ov2680_remove, -- With Best Regards, Andy Shevchenko
