On Wed, Jun 07, 2023 at 06:46:59PM +0200, Hans de Goede wrote:
> Most x86/ACPI boards use the ov2680 with a 19.2 MHz xvclk,
> rather then the expected 24MHz, add support for this.
>
> Compensate for the lower clk by setting a higher PLL multiplier
> of 69 when using 19.2 MHz vs the default multiplier of 55 for
> a 24MHz xvclk.
...
> @@ -720,12 +736,19 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
I believe this call is solely the part of the ->probe() flow, hence...
...
> + if (i == ARRAY_SIZE(ov2680_xvclk_freqs)) {
> + dev_err(dev, "unsupported xvclk frequency %d Hz\n", sensor->xvclk_freq);
> return -EINVAL;
return dev_err_probe(...);
?
> }
--
With Best Regards,
Andy Shevchenko
