On Fri, 24 Sep 2010 18:17:17 +0100 (BST) Daniel Drake <dsd@xxxxxxxxxx> wrote: > This patch, which basically reverts 6d77444ac, fixes an occasional > on-boot or on-capture hang on the XO-1 laptop. > > It seems like the cafe hardware is flakier than we thought and that in > some cases, the commands get executed but are never reported as completed > (even if we substantially increase the delays before reading registers). > > Reintroduce the 1-second CAFE_SMBUS_TIMEOUT to catch and avoid this > strange hardware bug. >From a *quick* airport-lounge look, these all look OK, though the first one is a little sad. I think that a lot of problems come from trying to speak SMBUS to the sensor - it doesn't actually do that very well. With the via-camera driver, life got a lot better when I went to straight i2c transactions. Doing that with the cafe controller will be a little bit trickier, probably requiring the implementation of a simple bit-banging i2c driver. It's probably worth a try, though, when somebody gets a chance. Meanwhile, feel free to toss my Acked-by onto this set. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
