Hi, On 6/7/23 18:14, Andy Shevchenko wrote: > On Wed, Jun 7, 2023 at 6:58 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> On 6/7/23 17:40, Andy Shevchenko wrote: >>> On Wed, Jun 7, 2023 at 3:01 PM Sakari Ailus >>> <sakari.ailus@xxxxxxxxxxxxxxx> wrote: >>>> On Wed, Jun 07, 2023 at 10:40:34AM +0200, Hans de Goede wrote: >>>>> On 6/6/23 22:43, Andy Shevchenko wrote: > > ... > >>>>> *val = __get_unaligned_be24(buf); >>> >>> __without double underscore prefix >> >> include/asm-generic/unaligned.h >> >> defines __get_unaligned_be24() and not get_unaligned_be24(), I guess because 24bit is not a standard register width. > > Strange. Do you have some custom patches in the area? > > https://elixir.bootlin.com/linux/v6.4-rc5/source/include/asm-generic/unaligned.h#L112 > https://elixir.bootlin.com/linux/v6.4-rc5/source/include/asm-generic/unaligned.h#L90 No I do not have any custom patches in that area; and the wrapper you point to is right there... I somehow missed it, sorry. So I will drop the __ as requested when adding the switch-case implementation for v2. Regards, Hans
