On Tue, May 30, 2023 at 1:36 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 5/29/23 22:31, Andy Shevchenko wrote:
> > On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
...
> >> + switch (which) {
> >> + case V4L2_SUBDEV_FORMAT_TRY:
> >> + return v4l2_subdev_get_try_crop(&sensor->sd, state, pad);
> >> + case V4L2_SUBDEV_FORMAT_ACTIVE:
> >> + return &sensor->mode.crop;
> >> + }
> >> +
> >> + return NULL;
> >
> > I would move this to default: case.
>
> That may cause the reader of the code to think that there are other cases,
> which there are not. All possible values of enum v4l2_subdev_format_whence
> are already handled, otherwise the compiler would also complain.
Why do we care about that?
What is the common practice in the v4l2 subsystem?
> The "return NULL" is there to shut up other compiler warnings.
Can you elaborate (I mean if the default will be present)?
> I'll add a /* never reached */ to it to make this clear.
--
With Best Regards,
Andy Shevchenko
