On Mon, May 29, 2023 at 1:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Implement selection support. Modelled after ov5693 selection support,
> but allow setting sizes smaller then crop-size through set_fmt since
than
> that was already allowed.
...
> +static struct v4l2_rect *
> +__ov2680_get_pad_crop(struct ov2680_dev *sensor, struct v4l2_subdev_state *state,
> + unsigned int pad, enum v4l2_subdev_format_whence which)
> +{
> + switch (which) {
> + case V4L2_SUBDEV_FORMAT_TRY:
> + return v4l2_subdev_get_try_crop(&sensor->sd, state, pad);
> + case V4L2_SUBDEV_FORMAT_ACTIVE:
> + return &sensor->mode.crop;
> + }
> +
> + return NULL;
I would move this to default: case.
> +}
--
With Best Regards,
Andy Shevchenko
