On Mon, May 29, 2023 at 08:36:27PM +0200, Konrad Dybcio wrote: > On 29.05.2023 20:16, Stephan Gerhold wrote: > > Reserved memory can be either looked up using the generic function > > of_address_to_resource() or using the special of_reserved_mem_lookup(). > > The latter has the advantage that it ensures that the referenced memory > > region was really reserved and is not e.g. status = "disabled". > > > > of_reserved_mem also supports allocating reserved memory dynamically at > > boot time. This works only when using of_reserved_mem_lookup() since > > there won't be a fixed address in the device tree. > > > > Switch the code to use of_reserved_mem_lookup(). There is no functional > > difference for static reserved memory allocations. > > > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > --- > > See e.g. [1] for an example of dynamically allocated reserved memory. > > (This patch does *not* depend on [1] and is useful without as well...) > > > > [1]: https://lore.kernel.org/linux-arm-msm/20230510-dt-resv-bottom-up-v1-5-3bf68873dbed@xxxxxxxxxxx/ > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > > > drivers/media/platform/qcom/venus/firmware.c | 24 +++++++++++++----------- > > 1 file changed, 13 insertions(+), 11 deletions(-) > > > [...] > > > - mem_va = memremap(r.start, *mem_size, MEMREMAP_WC); > > + mem_va = memremap(*mem_phys, *mem_size, MEMREMAP_WC); > > if (!mem_va) { > > - dev_err(dev, "unable to map memory region: %pR\n", &r); > > + dev_err(dev, "unable to map memory region %pa size %#zx\n", mem_phys, *mem_size); > Nit : I'm not sure which is more useful, but many mapping functions > seem to prefer printing > > start, start+size-1 > > instead of > > start, size > > on failure. > Shrug, both is fine for me. I just used this because the qcom remoteproc usages of of_address_to_resource() that I also patched already seemed to log it similar to this. If someone wants me to resend this with start, start+size-1 as suggested by Konrad (or something else) then just let me know. :) Thanks, Stephan
