Hello Mauro,
On Sun, May 14, 2023 at 02:04:07PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> On Sat, May 13, 2023 at 07:36:26PM +0100, Mauro Carvalho Chehab wrote:
> > Em Sat, 13 May 2023 19:59:31 +0200
> > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> escreveu:
> > > this patch was generated using coccinelle, but I aligned the result to
> > > the per-file indention.
> > >
> > > If you don't like the cleanups that are orthogonal to this patch, just
> > > tell me, then I can drop this change from the patch. Also if you want it
> > > split per driver or directory for improved patch count numbers, please
> > > tell me.
> > >
> > > Also I didn't Cc: all the individual maintainers to not exceed the
> > > allowed length of To: and Cc:. If this patch will be split I can extend
> > > the audience accordingly.
> >
> > Sounds good to me.
> >
> > > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> > > index 17465fcf28e3..7b26ba72ff2a 100644
> > > --- a/drivers/media/i2c/ov5648.c
> > > +++ b/drivers/media/i2c/ov5648.c
> > > @@ -2616,7 +2616,7 @@ static struct i2c_driver ov5648_driver = {
> > > .of_match_table = ov5648_of_match,
> > > .pm = &ov5648_pm_ops,
> > > },
> > > - .probe_new = ov5648_probe,
> > > + .probe = ov5648_probe,
> > > .remove = ov5648_remove,
> > > };
> >
> > Nit: you should probably remove the extra spaces from .remove
> > or align .probe here.
>
> Fixed here. This is the only change in v2.
>
> (There are a few more instances I'd call a bit strange, but I didn't fix
> these. E.g. drivers/media/dvb-frontends/au8522_decoder.c where the = for
> all members of au8522_driver are aligned but the .driver one. Then
> however .driver.name's = is aligned again. *shrug*)
>
>
> > Are you planning to merge this via I2C tree?
> > If so:
> >
> > Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> No, please take it via your tree. There are still a few more subsystems
> that must be converted before struct i2c_driver can be changed. There is
> no urge and I prefer to make it slow over coordinating all drivers
> changing via the i2c tree.
I don't find this change in next. After you initial feedback I thought
this would go in quickly. Did I miss something? Did this patch fell
through the cracks?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
