Em Sat, 13 May 2023 19:59:31 +0200
Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> escreveu:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Doing some minor cleanups en passant (whitespace cleanups, drop & from
> function pointers.)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
>
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
>
> If you don't like the cleanups that are orthogonal to this patch, just
> tell me, then I can drop this change from the patch. Also if you want it
> split per driver or directory for improved patch count numbers, please
> tell me.
>
> Also I didn't Cc: all the individual maintainers to not exceed the
> allowed length of To: and Cc:. If this patch will be split I can extend
> the audience accordingly.
Sounds good to me.
> diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> index 17465fcf28e3..7b26ba72ff2a 100644
> --- a/drivers/media/i2c/ov5648.c
> +++ b/drivers/media/i2c/ov5648.c
> @@ -2616,7 +2616,7 @@ static struct i2c_driver ov5648_driver = {
> .of_match_table = ov5648_of_match,
> .pm = &ov5648_pm_ops,
> },
> - .probe_new = ov5648_probe,
> + .probe = ov5648_probe,
> .remove = ov5648_remove,
> };
Nit: you should probably remove the extra spaces from .remove
or align .probe here.
-
Are you planning to merge this via I2C tree?
If so:
Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Regards,
Mauro
