Hi Laurent, On Thu, Apr 27, 2023 at 08:27:52PM +0300, Laurent Pinchart wrote: > > > I'm also wondering, wouldn't it be better to use notifier_dev(notifier) > > > as the dev argument to dev_dbg(), and print dev_name(sd->dev) in the > > > format string ? That's what you're doing below. > > > > Once there is a match, yes. But if that fails to happen, fwnodes are the > > most relevant... > > My main point was about using notifier_dev(notifier) as the dev argument > to dev_dbg(), and printing sd in the message. The notifier seems to be > the core object to me here, I think that's what we should use as context > for dev_dbg(). Ah, yes, this makes sense, I've actually already made that change. -- Sakari Ailus
