On Mon, Apr 17, 2023 at 09:30:49AM +0200, Uwe Kleine-König wrote: > Hello Laurent, > > On Mon, Apr 17, 2023 at 09:19:28AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 17, 2023 at 08:02:03AM +0200, Uwe Kleine-König wrote: > > > On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-König wrote: > > > > Hello, > > > > > > > > this series adapts the platform drivers below drivers/pci to use the > > > > > > copy&paste failure here: s/pci/media/ of course. > > > > > > > .remove_new() callback. Compared to the traditional .remove() callback > > > > .remove_new() returns no value. This is a good thing because the driver core > > > > doesn't (and cannot) cope for errors during remove. The only effect of a > > > > non-zero return value in .remove() is that the driver core emits a warning. The > > > > device is removed anyhow and an early return from .remove() usually yields a > > > > resource leak. > > > > > > > > By changing the remove callback to return void driver authors cannot > > > > reasonably assume any more that there is some kind of cleanup later. > > > > > > > > Only three drivers needed some preparation first to make sure they > > > > return 0 unconditionally in their remove callback. Then all drivers > > > > could be trivially converted without side effects to .remove_new(). > > > > > > > > The changes to the individual drivers are all orthogonal. If I need to > > > > resend some patches because of some review feedback, I'd like to only > > > > send the patches that actually needed changes, so please pick up the > > > > remaining patches that don't need changing to reduce the amount of mail. > > > > > > I didn't hear anything back about application of this series. Is there a > > > blocker somewhere? > > > > I think the series got applied to the master branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git. > > It should thus appear in v6.4. > > I guess that linux-stable.git is a copy&paste failure (and it's not > there). I don't see the series in the master branch of > git://linuxtv.org/media_tree.git either. Oops sorry. It was a copy & paste mistake indeed, I meant git://linuxtv.org/media_stage.git > .. a bit later ... > > ah, it's in git://linuxtv.org/mchehab/media-next.git > > I guess I was just to quick and probably the series will be included in > today's next. -- Regards, Laurent Pinchart
