Hi Hans, On Thursday 16 September 2010 12:36:34 Hans Verkuil wrote: > > On Monday 13 September 2010 19:06:20 Hans Verkuil wrote: > >> On Monday, September 13, 2010 17:27:52 Sakari Ailus wrote: [snip] > >> > What we currently have is this, not in upstream: > >> > > >> > --- > >> > /* SMIA-type sensor information */ > >> > #define V4L2_CID_MODE_CLASS_BASE (V4L2_CTRL_CLASS_MODE | 0x900) > >> > #define V4L2_CID_MODE_CLASS (V4L2_CTRL_CLASS_MODE | 1) > >> > #define V4L2_CID_MODE_FRAME_WIDTH (V4L2_CID_MODE_CLASS_BASE+1) > >> > #define V4L2_CID_MODE_FRAME_HEIGHT (V4L2_CID_MODE_CLASS_BASE+2) > >> > #define V4L2_CID_MODE_VISIBLE_WIDTH (V4L2_CID_MODE_CLASS_BASE+3) > >> > #define V4L2_CID_MODE_VISIBLE_HEIGHT (V4L2_CID_MODE_CLASS_BASE+4) > >> > #define V4L2_CID_MODE_PIXELCLOCK (V4L2_CID_MODE_CLASS_BASE+5) > >> > #define V4L2_CID_MODE_SENSITIVITY (V4L2_CID_MODE_CLASS_BASE+6) > > > > --- > > > >> > The pixel clock is read-only but some of the others should likely be > >> > changeable. > >> > >> It is very similar to the VIDIOC_G/S_DV_TIMINGS ioctls. I think we should > >> look into adding an e.g. V4L2_DV_SMIA_SENSOR type or something along > >> those lines. > > > > I'm not sure if sensivity would fit in there. The rest probably would. > > > >> I'm no sensor expert, so I don't know what sort of timing information is > >> needed for the various sensor types. But I'm sure there are other people > >> who have this knowledge. It would be useful if someone can list the > >> information that you need from the various sensor types. Based on that > >> we can see if this ioctl is a good fit. > > > > Another possibility could be to report the information using the media > > controller framework and an upcoming MEDIA_IOC_ENTITY_INFO ioctl. > > Are you talking about timing information? That doesn't belong in the media > framework. But I think I didn't quite understood what you meant here. Driver need to report driver-specific entity information (such as extension unit GUIDs for the UVC driver for instance). The idea was to add a media controller ioctl for that. Sensor information could be reported using the same mechanism. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
