Hi
>Le jeudi 16 mars 2023 à 10:47 +0000, John Cox a écrit :
>> Hi
>>
>> > Hi John,
>> >
>> > Le vendredi 10 mars 2023 à 19:41 +0000, John Cox a écrit :
>> > > Add fourccs for Broadcom 8 and 10-bit packed 128 byte column formats to
>> > > videodev2.h
>> > >
>> > > Signed-off-by: John Cox <jc@xxxxxxxxxxxxx>
>> > > ---
>> > > include/uapi/linux/videodev2.h | 2 ++
>> > > 1 file changed, 2 insertions(+)
>> > >
>> > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> > > index 1befd181a4cc..a836322ae5d8 100644
>> > > --- a/include/uapi/linux/videodev2.h
>> > > +++ b/include/uapi/linux/videodev2.h
>> > > @@ -656,6 +656,8 @@ struct v4l2_pix_format {
>> > > #define V4L2_PIX_FMT_P010_4L4 v4l2_fourcc('T', '0', '1', '0') /* 12 Y/CbCr 4:2:0 10-bit 4x4 macroblocks */
>> > > #define V4L2_PIX_FMT_NV12_8L128 v4l2_fourcc('A', 'T', '1', '2') /* Y/CbCr 4:2:0 8x128 tiles */
>> > > #define V4L2_PIX_FMT_NV12_10BE_8L128 v4l2_fourcc_be('A', 'X', '1', '2') /* Y/CbCr 4:2:0 10-bit 8x128 tiles */
>> > > +#define V4L2_PIX_FMT_NV12_C128 v4l2_fourcc('C', 'N', '1', '2') /* Y/CbCr 4:2:0 128 byte columns */
>> > > +#define V4L2_PIX_FMT_P030_C128 v4l2_fourcc('C', 'N', '3', '0') /* Y/CbCr 4:2:0 10-bit packed 128 byte columns */
>> >
>> > I really should have asked on first review, sorry about this, but where does
>> > P030 comes from ? I didn't find any new format that would be called
>> > V4L2_PIX_FMT_P030.
>>
>> Its the name used in the, already upstream, DRM definitions for the same
>> format. I thought I'd try to be consistent.
>
>Fair enough. For this patch too:
>
>Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
Is there anythiong else I need to / can do to get this lot accepted?
Thanks
John Cox
