Re: [PATCH] Illuminators control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, September 13, 2010 09:08:36 Laurent Pinchart wrote:
> Hi,
> 
> On Saturday 11 September 2010 11:03:50 Jean-Francois Moine wrote:
> 
> > @@ -419,6 +421,8 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum 
> v4l2_ctrl_type *type,
> >  	case V4L2_CID_AUDIO_LIMITER_ENABLED:
> >  	case V4L2_CID_AUDIO_COMPRESSION_ENABLED:
> >  	case V4L2_CID_PILOT_TONE_ENABLED:
> > +	case V4L2_CID_ILLUMINATORS_1:
> > +	case V4L2_CID_ILLUMINATORS_2:
> >  		*type = V4L2_CTRL_TYPE_BOOLEAN;
> >  		*min = 0;
> >  		*max = *step = 1;
> 
> I would prefer integer controls for this, as we will need to support dimmable 
> illuminators.
> 
> 

Don't. That should be a separate control. I expect that the brightness is
something you touch a lot less than the on/of controls. Anyway, I think it
makes a lot more sense to separate these two functions.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux