On 2023/3/8 19:07, Krzysztof Kozlowski wrote: > On 08/03/2023 12:03, Jack Zhu wrote: >> >> >> On 2023/3/8 18:33, Krzysztof Kozlowski wrote: >>> On 07/03/2023 10:46, Jack Zhu wrote: >>>> >>>> >>>> On 2023/3/3 16:43, Krzysztof Kozlowski wrote: >>>>> On 02/03/2023 10:19, jack.zhu wrote: >>>>>> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile >>>>>> to enable building of the Starfive Camera subsystem driver. >>>>>> >>>>>> Signed-off-by: jack.zhu <jack.zhu@xxxxxxxxxxxxxxxx> >>>>>> --- >>>>>> drivers/media/platform/Kconfig | 1 + >>>>>> drivers/media/platform/Makefile | 1 + >>>>>> drivers/media/platform/starfive/Kconfig | 18 ++++++++++++++++++ >>>>>> drivers/media/platform/starfive/Makefile | 14 ++++++++++++++ >>>>> >>>>> This is not a separate commit. If it were, it would mean you just added >>>>> dead code in previous commits, so why adding dead code in first place? >>>>> >>>> >>>> The previous patches are made according to the module function.I think >>>> it is helpful to explain the composition of the code file. >>>> >>>> stf_camss[patch 9] as a platform device manages all resources including >>>> ISP and VIN. ISP/VIN [patch 7/8]as a sub-device needs to access other >>>> resources managed by stf_camss.There is mutual reference between them. >>>> Therefore, this patch is used for the overall compilation of the starfive >>>> directory. >>> >>> So previous code is dead? Again, what is the reason for adding dead >>> code? Mutual reference is not the answer. >>> >> >> Maybe I need to merge the previous patches[6-11] into one patch to submit? > > I gave you the recommendation in my first reply. What's wrong with it? > Thank you for your suggestion and the recommended action which I just confirmed it in detail in our previous messages.I agree with you that this is not a separate commit.I will merge them in the next version to be a single commit. This is my first time to submit code to the community.There are many things to learn. I sincerely thank you for your patient help and advice. > Best regards, > Krzysztof >
