Hi Sakari I don't see this patch being collected for 6.3 while I recall that based on the discussion we concluded we can have these in and the iterate on top ? Thanks j On Tue, Jan 17, 2023 at 11:06:00AM +0100, Jacopo Mondi wrote: > Currently the imx258 driver requires to have the 'rotation' device node > property specified in DTS with a fixed value of 180 degrees. > > The "rotation" fwnode device property is intended to allow specify the > sensor's physical mounting rotation, so that it can be exposed through > the read-only V4L2_CID_CAMERA_SENSOR_ROTATION control and applications > can decide how to compensate for that. > > The imx258 driver has read-only VFLIP and HFLIP enabled, resulting in > a 180 degrees image rotation being produced by the sensor. But this > doesn't imply that the physical mounting rotation should match the > driver's implementation. > > I took into the series Robert's patch that register device node properties and > on top of that register flips controls, in order to remove the hard requirement > of the 180 degrees rotation property presence. > > Jacopo Mondi (2): > media: imx258: Register H/V flip controls > media: imx258: Remove mandatory 180 degrees rotation > > Robert Mader (1): > media: imx258: Parse and register properties > > drivers/media/i2c/imx258.c | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > -- > 2.39.0 >
