Hi Dave, On Thu, Feb 09, 2023 at 12:40:43PM +0000, Dave Stevenson wrote: > > +static struct i2c_driver ov01a10_i2c_driver = { > > + .driver = { > > + .name = "ov01a10", > > + .pm = &ov01a10_pm_ops, > > + .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids), > > As you're only supporting ACPI here, make ACPI a dependency in Kconfig? I wonder if || COMPILE_TEST should be added as there's nothing ACPI specific in this driver, it's that only ACPI is supported. Very few drivers have firmware type dependencies currently. -- Sakari Ailus