Re: [PATCH v7 0/7] i2c-atr and FPDLink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 18, 2023 at 02:40:24PM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> You can find the v6 from:
> 
> https://lore.kernel.org/all/20230105140307.272052-1-tomi.valkeinen@xxxxxxxxxxxxxxxx/
> 
> Main changes:
> 
> * i2c-atr: Use bus notifier. This allows us to drop the patch that adds
>   the attach_client/detach_client callbacks. On the downside, it removes
>   the option for error handling if the translation setup fails, and also
>   doesn't provide us the pointer to the i2c_board_info. I belive both
>   are acceptable downsides.
> 
> * Use fwnode in the fpdlink drivers instead of OF
> 
> * Addressed all the review comments (I hope)
> 
> * Lots of cosmetic or minor fixes which I came up while doing the fwnode
>   change

I believe my comments to the first driver applies to the next two, so please
address them whenever you are agree / it's possible / it makes sense.

About ATR implementation. We have the i2c bus (Linux representation of
the driver model) and i2c_adapter and i2c_client objects there. Can't we
have an i2c_client_aliased in similar way and be transparent with users?

It's just a thought which may be well far from the possibility
to be implemented if even possible...

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux