On Wed, Jan 18, 2023, at 16:39, Mike Isely wrote:
> That doesn't seem right. The pvrusb2 module should reference that
> symbol like any other. There is no special treatment of it within
> pvrusb2 - so why is that requiring special treatment here?
The problem is that VIDEO_PVRUSB2_DVB is a 'bool' symbol, not
a 'tristate', so the existing 'depends on DVB_CORE' is not sufficient.
Another way to do this would be to prevent VIDEO_PVRUSB2 from
being built-in when DVB_CORE is a module:
config VIDEO_PVRUSB2
tristate "Hauppauge WinTV-PVR USB2 support"
depends on VIDEO_DEV && I2C
+ depends on DVB_CORE || !DVB_CORE
select VIDEO_TUNER
select VIDEO_TVEEPROM
select VIDEO_CX2341X
but that doesn't feel right for users that don't care about DVB
support.
> Is it possible that dvb_module_probe and dvb_module_release are not
> exported? (Or that there are two corresponding different exported
> symbol names that pvrusb2 should be using instead?)
No.
Arnd
