Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 03, 2010 at 12:20:54AM +0300, Maxim Levitsky wrote:
> Also in the future I think I should make the
> ir_raw_event_store_with_filter the default submit function for all
> drivers, and then I could drop that silly '_with_filter" thing
> (Couldn't think for a better name for this function...)

I agree. Perhaps it would even be possible to merge 
ir_raw_event_store_with_filter and ir_raw_event_store. The automatic 
merger of consecutive pulse-pulse events or space-space events should 
help simplify some drivers...

> > Wouldn't DEFINE_RAW_EVENT(ev); be more in line with the kernel 
> > coding style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc).
> Of course, nothing against that.

DEFINE_RC_RAW_EVENT() is probably better by the way...

-- 
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux