Re: [PATCH v4 1/2] media: ov5640: Fix soft reset sequence and timings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 03, 2023 at 06:07:38PM +0100, Jacopo Mondi wrote:
> > +	/* software standby: allows registers programming;
> > +	 * exit at restore_mode() for CSI, s_stream(1) for DVP
> > +	 */
> 
> Multiline comments are usually written as
> 
> 	/*
>          * Software standby: allows registers programming;
> 	 * exit at restore_mode() for CSI, s_stream(1) for DVP
> 	 */
> 
> It's a trivial change, I'm not collecting patches so I can't offer to
> change it when doing so, but maybe Sakari could help with that so that
> you don't have to send a new version ? (if that's the only comment you
> receive ofc)

Works for me.

> 
> The patch looks good to me
> 
> Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxxx>

Thanks!

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux