Re: [PATCH] media: sun4i-csi: Use CSI_INT_STA_REG name, fix typo in a comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oleg,

On Mon, Jan 09, 2023 at 11:24:56PM +0300, Oleg Verych wrote:

Please add a more elaborate description of the patch here. Looks good
otherwise.

> ---
>  drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
> index a3e826a75..95b5633b7 100644
> --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
> +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
> @@ -245,7 +245,7 @@ static int sun4i_csi_start_streaming(struct vb2_queue *vq, unsigned int count)
>  	 * We need a scratch buffer in case where we'll not have any
>  	 * more buffer queued so that we don't error out. One of those
>  	 * cases is when you end up at the last frame to capture, you
> -	 * don't havea any buffer queued any more, and yet it doesn't
> +	 * don't have any buffer queued any more, and yet it doesn't
>  	 * really matter since you'll never reach the next buffer.
>  	 *
>  	 * Since we support the multi-planar API, we need to have a
> @@ -311,7 +311,7 @@ static int sun4i_csi_start_streaming(struct vb2_queue *vq, unsigned int count)
>  	writel(CSI_BUF_CTRL_DBE, csi->regs + CSI_BUF_CTRL_REG);
>  
>  	/* Clear the pending interrupts */
> -	writel(CSI_INT_FRM_DONE, csi->regs + 0x34);
> +	writel(CSI_INT_FRM_DONE, csi->regs + CSI_INT_STA_REG);
>  
>  	/* Enable frame done interrupt */
>  	writel(CSI_INT_FRM_DONE, csi->regs + CSI_INT_EN_REG);

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux