Re: [PATCH 0/4] media: Drop empty platform remove functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

On Tue, Dec 13, 2022 at 3:36 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> Hello,
>
> this series removes all platform remove functions that only return zero
> below drivers/media. There is no reason to have these, as the only
> caller is platform core code doing:
>
>         if (drv->remove) {
>                 int ret = drv->remove(dev);
>
>                 if (ret)
>                         dev_warn(...)
>         }
>
> (in platform_remove()) and so having no remove function is both
> equivalent and simpler.
>
> Uwe Kleine-König (4):
>   media: ti/davinci: vpbe_osd: Drop empty platform remove function
>   media: ti/davinci: vpbe_venc: Drop empty platform remove function
Ive reviewed the above two patches. I believe Hans will pick this up
soon for v6.3.

Cheers,
Prabhakar


>   media: rc/ir-rx51: Drop empty platform remove function
>   media: chips-media/imx-vdoa: Drop empty platform remove function
>
>  drivers/media/platform/chips-media/imx-vdoa.c | 6 ------
>  drivers/media/platform/ti/davinci/vpbe_osd.c  | 6 ------
>  drivers/media/platform/ti/davinci/vpbe_venc.c | 6 ------
>  drivers/media/rc/ir-rx51.c                    | 6 ------
>  4 files changed, 24 deletions(-)
>
>
> base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> --
> 2.38.1
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux