On 05/01/2023 18:23, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
>
Subject: drop redundant "schema for".
> Add binding schema for the OmniVision OV8858 8 Megapixels camera sensor.
>
Thank you for your patch. There is something to discuss/improve.
> +properties:
> + compatible:
> + const: ovti,ov8858
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: XVCLK external clock
> +
> + clock-names:
> + const: xvclk
> +
> + dvdd-supply:
> + description: Digital Domain Power Supply
> +
> + avdd-supply:
> + description: Analog Domain Power Supply
> +
> + dovdd-supply:
> + description: I/O Domain Power Supply
> +
> + powerdown-gpios:
> + maxItems: 1
No need for maxItems here - it is coming from gpio-consumer-common.
> + description: PWDNB powerdown GPIO (active low)
> +
> + reset-gpios:
> + maxItems: 1
> + description: XSHUTDN reset GPIO (active low)
> +
> + port:
> + description: MIPI CSI-2 transmitter port
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + minItems: 1
> + maxItems: 4
> +
> + required:
> + - data-lanes
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - assigned-clocks
> + - assigned-clock-rates
These should not be required.
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/pinctrl/rockchip.h>
Drop, not needed.
> + #include <dt-bindings/clock/rk3399-cru.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c2 {
i2c
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ov8858: camera@36 {
> + compatible = "ovti,ov8858";
> + reg = <0x36>;
> +
> + clocks = <&cru SCLK_CIF_OUT>;
> + clock-names = "xvclk";
> + assigned-clocks = <&cru SCLK_CIF_OUT>;
> + assigned-clock-rates = <24000000>;
> +
> + dovdd-supply = <&vcc1v8_dvp>;
> +
> + reset-gpios = <&gpio1 RK_PA4 GPIO_ACTIVE_LOW>;
> + powerdown-gpios = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>;
> +
> + port {
> + ucam_out: endpoint {
> + remote-endpoint = <&mipi_in_ucam>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> + };
> + };
> +...
> --
> 2.38.1
>
Best regards,
Krzysztof
