From: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Hello, this is a new version of of Nicholas' first submission available at https://lore.kernel.org/all/20221106171129.166892-2-nicholas@xxxxxxxxxxxxx/ This is a re-write of the previous version so I've restarted numeration from 0 even if in this version I have not changed the register tables. Functionally the most notable difference is the addition of support for binned mode in 4 data lanes mode. There is more space for optimization on top of this series, in example the register tables can be reworked to share more common settings between modes. I have started the effort, but as it is a tedious and error-prone work I would rather have this first version merged and the iterate on top. Programming of the analog crop rectangle and output size could also be made parametric, but the current modes have a few undocumented registers and I didn't feel like biting the bullet and see if the can be safely removed or not. Also, the BSP driver mentions a "not well supported" R1A version of the chip. I would be in favour of removing it if no one oppose. Images are still rather "dark" when tested with libcamera but preview is working as expected in both modes (full res and half-res binned mode) and with 2 and 4 data lanes. Nicholas could you let me know if things are fine with you here ? Thanks j Jacopo Mondi (1): dt-bindings: media: Add schema for OmniVision OV8858 Nicholas Roth (1): media: i2c: Add driver for OmniVision OV8858 .../bindings/media/i2c/ovti,ov8858.yaml | 109 + MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov8858.c | 1989 +++++++++++++++++ 5 files changed, 2121 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml create mode 100644 drivers/media/i2c/ov8858.c -- 2.38.1
