Re: [PATCH v2] media: aspeed: Fix return value check in aspeed_video_debugfs_create()

[Andrew Lunn <andrew@xxxxxxx>]

On Sat, Nov 26, 2022 at 02:28:13AM +0000, Zheng Yongjun wrote:
> In case of error, the function debugfs_create_file() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Fixes: 52fed10ad756 ("media: aspeed: add debugfs")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>

Please see:

https://patchwork.kernel.org/project/linux-wireless/patch/20200429101526.GA2094124@xxxxxxxxx/

and there are other examples. Just delete all the checks.

	Andrew