Hi Stefan
On 11/26/22 8:12 PM, Stefan Wahren wrote:
Hi Umang,
Am 21.11.22 um 22:47 schrieb Umang Jain:
This series aims to upport bcm2835-isp from the RPi kernel [1] and is a
independent subset of earlier series [2] posted to upport CSI-2/CCP2
receiver IP core("Unicam) + the ISP driver found in BCM283x and
compatible
SoCs (namely BCM2711). Unicam is still under active development to work
with multistream support to get into mainline. Hence only the ISP driver
will remain the primary area of this series.
thanks for working on this. But honestly i would prefer that vchiq
comes out of staging before adding more features. As Greg said some
time ago staging is not a place to "dump code and run away". These new
files are in the same bad shape as the rest of vc04 before the
clean-up here in staging started.
Certainly, I am not here to do that - but I am still learning the ropes.
If the staging issue is becoming a blocker for bcm2835-isp going
upstream, I would be happy to help here! Though I must mention that I
still have limited visibility so my aim would be to chart out a plan of
things needed to be done to get vc04_services out of staging!
I agree that VCSM is on the TODO list for vchiq, but this driver is
not necessary for making bcm2835-audio & bcm2835-camera leave staging.
It just binds more resources on a new feature.
I see two TODO files in vc04_services:
./bcm2835-camera/TODO
./interface/TODO
One of the bcm2835-camera TODO points to the vc-sm-cma driver itself. So
that's address in the series. The other remaining one - I will need to
take a deeper look before commenting on it.
The main chunk of TODO are in vc04_services/interfaces/TODO. Doing a
cursory reading of them suggests that these apply to *all* vc04_services
components? Am I right?
Are these are the specific bits of cleanup you are referring to in your
comment?
Unfortuntately i hadn't much time to work on vchiq by myself.
Just my two cents
Stefan
