Re: [PATCH 1/1] ov08x40: remove() now returns void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kieran,

On Mon, Nov 21, 2022 at 06:00:15PM +0000, Kieran Bingham wrote:
> Hi Sakari,
> 
> Quoting Sakari Ailus (2022-11-21 17:34:53)
> > The return type of the driver's remove() callback is now void. This driver
> > got merged while the return type got changed tree-wide. Fix this.
> > 
> > Fixes: 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> Kieran: Mon, 21 Nov 2022 17:34:47 +0000
> Sakari: Mon, 21 Nov 2022 19:34:53 +0200
> 
> Aha, so I got my v1 out 6 seconds before you ;-) Quite the tense race
> ...
> 
> But I'll not worry - yours is probably already in your tree, so:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

Thanks!

The SMTP standard does not define what time the Date: header signifies, it
could have been set by the sender or another server later on... but in this
case git send-email probably set it in both cases.

I haven't pushed my tree to linuxtv.org yet and yours has a better commit
message so I'll take it instead.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux