Hi, On 11/14/22 13:20, Andy Shevchenko wrote: > On Thu, Oct 20, 2022 at 09:55:33PM +0200, Hans de Goede wrote: >> Depending on which order userspace makes various v4l2 calls, the sensor >> might still be powered down when set_fmt is called. >> >> What should really happen here is delay the writing of the mode-related >> registers till streaming is started, but for now use the same quick fix >> as the atomisp_ov2680 code and call power_up() from set_fmt() in >> combination with keeping track of the power-state to avoid doing the >> power-up sequence twice. > > ... > >> + /* s_power has not been called yet for std v4l2 clients (camorama) */ >> + power_up(sd); > > if camorama is fixed, will this become a problem? This is not a camorama issue but an issue with the atomisp2 + sensor driver combination. camorama uses a slightly different order in which various v4l2 ioctls are done so it needs the power_up() here. Note that power_up() checks + sets a flag so that if it gets called multiple times it only does the actual power-up once. Regards, Hans
