On 14/11/2022 10:44, Aakarsh Jain wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] >> Sent: 14 November 2022 13:22 >> To: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx >> Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; >> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; >> ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx; >> benjamin.gaignard@xxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; >> stanimir.varbanov@xxxxxxxxxx; dillon.minfei@xxxxxxxxx; >> david.plowman@xxxxxxxxxxxxxxx; mark.rutland@xxxxxxx; >> robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; andi@xxxxxxxxxxx; >> alim.akhtar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx; >> pankaj.dubey@xxxxxxxxxxx; smitha.t@xxxxxxxxxxx >> Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 >> hardware for Exynos 3250 SoC >> >> On 14/11/2022 06:46, Aakarsh Jain wrote: >>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for >> >> Please run scripts/checkpatch.pl and fix reported warnings. >> > Do you mean warnings on "5441e9dafdfc6dc40fa" commit? Or on this patch? > > I am running like this : ./scripts/checkpatch.pl patch_file, it does not show any warnings. > > or am I missing anything while running checkpatch on the current patch? Eh, you're right... checkpatch does not catch it. You need to fix syntax - drop quotes, use proper commit title: https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/process/submitting-patches.rst#L100 Best regards, Krzysztof
