On Wed, 5 Oct 2022 at 20:07, Jacopo Mondi <jacopo@xxxxxxxxxx> wrote: > > Setup all the registered controls at s_stream(1) time instead of > manually configure gains. > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> Ah, lovely. I'm surprised it doesn't error out with no s_ctrl handler for link_freq when r/w though. Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > --- > drivers/media/i2c/ar0521.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c > index 26bb1b8f7453..d46a51332964 100644 > --- a/drivers/media/i2c/ar0521.c > +++ b/drivers/media/i2c/ar0521.c > @@ -460,7 +460,7 @@ static int ar0521_set_stream(struct ar0521_dev *sensor, bool on) > if (ret) > goto err; > > - ret = ar0521_set_gains(sensor); > + ret = __v4l2_ctrl_handler_setup(&sensor->ctrls.handler); > if (ret) > goto err; > > -- > 2.37.3 >
