Hi Yang, On Tue, Sep 20, 2022 at 05:13:11PM +0800, Yang Yingliang wrote: > Hi, > > On 2022/9/20 16:33, Sakari Ailus wrote: > > Hi Yang, > > > > On Mon, Sep 19, 2022 at 11:58:43PM +0800, Yang Yingliang wrote: > > > In the probe path, dev_err() can be replaced with dev_err_probe() > > > which will check if error code is -EPROBE_DEFER. > > I don't really disagree with changing to dev_err_probe(). But I would like > > to ask how have you selected the drivers and calls calls in them that you > > do change. > The drivers that check if error code is EPROBE_DEFER when handling error > case in probe > path. Ah, I see you're only changing this where the printing of the error was conditional on the error being -EPROBE_DEFER. Many drivers still do print an error when returning -EPROBE_DEFER but I guess they can be handled separately. Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> -- Regards, Sakari Ailus
