Hi Yang, On Mon, Sep 19, 2022 at 11:58:43PM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER. I don't really disagree with changing to dev_err_probe(). But I would like to ask how have you selected the drivers and calls calls in them that you do change. E.g. the imx274 driver has a number of such calls and the patch appears to change one of them. Other drivers similar to imx274 (e.g. other sensor drivers) do use dev_err() as well. I wonder how difficult it would be to do this more systematically with Coccinelle. -- Kind regards, Sakari Ailus
