Hi Yang,
Thank you for the patch.
On Thu, Sep 15, 2022 at 11:03:19PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/ti/omap3isp/isp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c
> index a6052df9bb19..5d6867b8f197 100644
> --- a/drivers/media/platform/ti/omap3isp/isp.c
> +++ b/drivers/media/platform/ti/omap3isp/isp.c
> @@ -1886,8 +1886,7 @@ static int isp_initialize_modules(struct isp_device *isp)
>
> ret = omap3isp_ccp2_init(isp);
> if (ret < 0) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(isp->dev, "CCP2 initialization failed\n");
> + dev_err_probe(isp->dev, ret, "CCP2 initialization failed\n");
> goto error_ccp2;
> }
>
--
Regards,
Laurent Pinchart
