On Thu, Sep 15, 2022 at 11:03:21PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/media/rc/gpio-ir-recv.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
> index 22e524b69806..8f1fff7af6c9 100644
> --- a/drivers/media/rc/gpio-ir-recv.c
> +++ b/drivers/media/rc/gpio-ir-recv.c
> @@ -74,13 +74,9 @@ static int gpio_ir_recv_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> gpio_dev->gpiod = devm_gpiod_get(dev, NULL, GPIOD_IN);
> - if (IS_ERR(gpio_dev->gpiod)) {
> - rc = PTR_ERR(gpio_dev->gpiod);
> - /* Just try again if this happens */
> - if (rc != -EPROBE_DEFER)
> - dev_err(dev, "error getting gpio (%d)\n", rc);
> - return rc;
> - }
> + if (IS_ERR(gpio_dev->gpiod))
> + return dev_err_probe(dev, PTR_ERR(gpio_dev->gpiod),
> + "error getting gpio\n");
Now the error number is no longer logged. That can't be good?
Sean
> gpio_dev->irq = gpiod_to_irq(gpio_dev->gpiod);
> if (gpio_dev->irq < 0)
> return gpio_dev->irq;
> --
> 2.25.1
