On 29/08/2022 14:28, Tuma, Martin (Digiteq Automotive) wrote: > > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Sunday, August 28, 2022 4:58 PM > To: Tuma, Martin (Digiteq Automotive) <Martin.Tuma@xxxxxxxxxxxxxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx <linux-media@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH 2/3] Added Xilinx PCIe DMA IP core driver > > On 22/08/2022 22:47, martin.tuma@xxxxxxxxxxxxxxxxxxxxx wrote: >> From: Martin Tůma <martin.tuma@xxxxxxxxxxxxxxxxxxxxx> >> >> The driver is based on the code provided by Xilinx at >> https://github.com/Xilinx/dma_ip_drivers > >>> Explain why this cannot be merged into existing Xilinx dma drivers > > The Xilinx XDMA IP core is a complex device that is bound to PCIe and > also handles stuff like MSI/MSI-X interrupts of the PCIe card/FPGA. > The FPGA IP core is different from those that already have drivers in > dma/xilinx so a new dma device would be required anyway. Just because it is different does not mean it requires a new driver... > > >> >> There are no significant functional changes in the code except >> of separating the core DMA driver functionality in a way that the code >> can be used by device drivers in the kernel. > > Use scripts/get_maintainers.pl to CC all maintainers and relevant > mailing lists. Patch will be ignored if you do not follow Linux kernel > process... > > Ok, thanks for the info, I have missed this in all the "how to submit > a patch to linux" info one has to go through. I don't understand your quoting style. You typed here my message instead of quoting. I recommend to use some standard mail clients so that emails are properly formatted. Best regards, Krzysztof