On 29/08/2022 14:47, Tuma, Martin (Digiteq Automotive) wrote: > > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Sunday, August 28, 2022 4:47 PM >> To: Tuma, Martin (Digiteq Automotive) <Martin.Tuma@xxxxxxxxxxxxxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx <linux-media@xxxxxxxxxxxxxxx> >> Subject: Re: [PATCH 1/3] Added platform module alias for the xiic I2C driver > >>> On 22/08/2022 22:47, martin.tuma@xxxxxxxxxxxxxxxxxxxxx wrote: >>> From: Martin Tůma <martin.tuma@xxxxxxxxxxxxxxxxxxxxx> > >> Thanks for the patch. Empty commits are not accepted, so instead you >> should explain here why do you need it. In general, your change should >> not be needed, so please explain in detail why do you think otherwise. > > The reason the alias is required is that without the "platform" prefix, loading > the xiic module does not work properly in the mgb4 module. I can not explain > exactly why as my knowledge of the module loading mechanism in linux/modprobe > is quite limited, but that's how it is. The mgb4 v4l2 module requires two modules > that are defined using MODULE_SOFTDEP() to be loaded prior to the mgb4 > module - the Xilinx I2C module and the Xilinx SPI module. The SPI module already > has the "platform" prefixed alias and loads fine, while the I2C doesn't and does > not get loaded without it. So I added the alias to make the loading work. > > I will add the info that the alias is required by the mgb4 module to the commit > message the next time I will send the fixed patches, thanks for pointing this out. Driver matches only by Devicetree, so instead of this patch you rather miss proper DTS. Best regards, Krzysztof
