Re: [PATCH v2 6/9] media: rkisp1: Don't pass the quantization to rkisp1_csm_config()

[paul.elder@xxxxxxxxxxxxxxxx]

On Tue, Aug 23, 2022 at 08:18:37PM +0300, Laurent Pinchart wrote:
> The rkisp1_csm_config() function takes a pointer to the rkisp1_params
> structure which contains the quantization value. There's no need to pass
> it separately to the function. Drop it from the function parameters.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Reviewed-by: Dafna Hirschfeld <dafna@xxxxxxxxxxxx>

Reviewed-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> index 8b4eea77af0d..163419624370 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> @@ -1076,7 +1076,7 @@ static void rkisp1_ie_enable(struct rkisp1_params *params, bool en)
>  	}
>  }
>  
> -static void rkisp1_csm_config(struct rkisp1_params *params, bool full_range)
> +static void rkisp1_csm_config(struct rkisp1_params *params)
>  {
>  	static const u16 full_range_coeff[] = {
>  		0x0026, 0x004b, 0x000f,
> @@ -1090,7 +1090,7 @@ static void rkisp1_csm_config(struct rkisp1_params *params, bool full_range)
>  	};
>  	unsigned int i;
>  
> -	if (full_range) {
> +	if (params->quantization == V4L2_QUANTIZATION_FULL_RANGE) {
>  		for (i = 0; i < ARRAY_SIZE(full_range_coeff); i++)
>  			rkisp1_write(params->rkisp1,
>  				     RKISP1_CIF_ISP_CC_COEFF_0 + i * 4,
> @@ -1562,11 +1562,7 @@ static void rkisp1_params_config_parameter(struct rkisp1_params *params)
>  	rkisp1_param_set_bits(params, RKISP1_CIF_ISP_HIST_PROP_V10,
>  			      rkisp1_hst_params_default_config.mode);
>  
> -	/* set the  range */
> -	if (params->quantization == V4L2_QUANTIZATION_FULL_RANGE)
> -		rkisp1_csm_config(params, true);
> -	else
> -		rkisp1_csm_config(params, false);
> +	rkisp1_csm_config(params);
>  
>  	spin_lock_irq(&params->config_lock);