Hello, This patch series fixes and improves color space support in the rkisp1 driver. The first two patches initialize the color space fields to default values on the ISP subdev video sink and source pads, and allow setting the color space on the ISP sink pad (this has no influence on the ISP configuration, and only serves to propagate the correct color space on the pipeline). Patch 3/9 fixes a bug in the ISP source pad configuration, which allowed setting a Bayer output format with a YUV input format, a clearly invalid configuration. Patch then 4/9 mimicks patch 2/9 by allowing setting of color space fields on the source pad. The next three patches configure the RGB to YUV matrix (in the CSM module) using the ISP source pad YCbCr encoding. Patch 5/9 fixes a small bug in color space handling that resulted in the sink pad quantization controlling the ISP output, instead of using the source pad quantization. Patch 6/9 is a small internal API refactoring, and finally patch 7/9 handles the CSM configuration. Patches 8/9 and 9/9 mimick 1/9 and 2/9 for the resizer subdevs, allowing propagation of the color space along the pipeline. If anyone is curious about how the matrix coefficients of patch 7/9 have been computed, see the script posted in [1] that will be merged in libcamera. [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-August/033183.html Laurent Pinchart (9): media: rkisp1: Initialize color space on ISP sink and source pads media: rkisp1: Allow setting color space on ISP sink pad media: rkisp1: Fix source pad format configuration media: rkisp1: Allow setting all color space fields on ISP source pad media: rkisp1: Configure quantization using ISP source pad media: rkisp1: Don't pass the quantization to rkisp1_csm_config() media: rkisp1: Configure CSM based on YCbCr encoding media: rkisp1: Initialize color space on resizer sink and source pads media: rkisp1: Allow setting color space on resizer sink pad .../platform/rockchip/rkisp1/rkisp1-common.h | 5 +- .../platform/rockchip/rkisp1/rkisp1-isp.c | 139 ++++++++++++++++-- .../platform/rockchip/rkisp1/rkisp1-params.c | 105 +++++++++---- .../platform/rockchip/rkisp1/rkisp1-resizer.c | 45 +++++- 4 files changed, 249 insertions(+), 45 deletions(-) -- Regards, Laurent Pinchart
