Hi Sakari, On 22-08-22, Sakari Ailus wrote: > On Mon, Aug 22, 2022 at 09:54:26AM +0200, Marco Felsch wrote: > > Hi Sakari, > > > > On 22-08-22, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Thu, Aug 18, 2022 at 04:47:11PM +0200, Marco Felsch wrote: > > > > Currently the driver turn off the power after probe and toggle it during > > > > .stream by using the .s_power callback. This is problematic since other > > > > callbacks like .set_fmt accessing the hardware as well which will fail. > > > > So in the end the default format is the only supported format. > > > > > > It'd be much better to add runtime PM support to the driver instead. > > > > I got your point, but didn't have the time for it right now, I will drop > > the patch from my v2. > > The API is different but generally involves doing more or less the same > what this and the 4th patch do together. I know :) as soon as I got feedback on my TC35 series [1] I give it a try and change it to dev-pm. [1] https://lore.kernel.org/linux-media/20220818143307.967150-1-m.felsch@xxxxxxxxxxxxxx/T/#t Regards, Marco > > -- > Sakari Ailus >
