Hi Sean,
Tue, Jul 05, 2022 at 06:43:55PM +0100, Sean Young wrote:
On Tue, Jul 05, 2022 at 11:53:58AM +0300, Marko Mäkelä wrote:
The flag LIRC_SCANCODE_FLAG_REPEAT was never set by rc_keydown().
Previously it was only set by rc_repeat(), but not all protocol
decoders invoke that function.
This should say _why_ you are making this change, not _what_ the change
is.
How would you find the following?
---
media: lirc: ensure lirc device receives repeats
Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement
reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag in
the LIRC messages.
Commit b66218fddfd29f315a103db811152ab0c95fb054
("media: lirc: ensure lirc device receives nec repeats") fixed it up for
those protocol drivers that may call rc_repeat().
---
Would you prefer to be mentioned as a co-developer?
Best regards,
Marko